Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device recovery flow, filter out recovery methods that aren't devices #2791

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix device recovery flow, filter out recovery methods that aren't devices #2791

merged 1 commit into from
Jan 20, 2025
+2 −1

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Jan 20, 2025 •
edited by github-actions bot
Loading

Fix device recovery flow, filter out recovery methods that aren't devices

Changes

  • Filter out recovery methods that aren't devices (seed phrase recovery method)

Tests

See device recovery flow e2e tests in this PR: #2790

🟡 Some screens were changed

@sea-snake sea-snake requested a review from lmuntaner January 20, 2025 10:34
lmuntaner
lmuntaner approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sea-snake sea-snake added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 053e161 Jan 20, 2025
67 checks passed
@sea-snake sea-snake deleted the sea-snake/fix-device-recovery branch January 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sea-snake @lmuntaner