Util getCredentialsOrigin #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sea-snake @LXIF please review |
sea-snake
reviewed
Jan 21, 2025
lmuntaner
force-pushed
the
lm-util-get-credentials-origin
branch
from
3850cbe to
3565ee7
Compare
|
@sea-snake ready for another review |
sea-snake
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure that users don't have a bad UX when logging in from different domains. The bad UX comes from having devices registered in different domains. Therefore, we want to avoid that a user can register devices in different domains.
In this PR, a new util is introduced to get the common origin of all user's device.
Changes
getCredentialsOrigin.DEFAULT_ORIGINfromfindWebauthnRpIdmove it to a constants file.Tests
🟡 Some screens were changed