Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text add current device page #2807

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Improve text add current device page #2807

merged 2 commits into from
Jan 22, 2025

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Jan 22, 2025 •
edited by github-actions bot
Loading

Motivation

Improve the text in the page to add the current device.

Changes

  • Text changes

Tests

Not necessary.

🟡 Some screens were changed

@lmuntaner lmuntaner marked this pull request as ready for review January 22, 2025 10:43
@lmuntaner lmuntaner requested a review from LXIF January 22, 2025 10:43
@lmuntaner
Copy link
Collaborator Author

@LXIF please review

@lmuntaner
Copy link
Collaborator Author

Page with text:

Screenshot 2025-01-22 at 11 46 11

LXIF
LXIF reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it has two dots. One second.

LXIF
LXIF approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmuntaner
Copy link
Collaborator Author

Now it has two dots. One second.

Thanks!

@lmuntaner lmuntaner added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit f296316 Jan 22, 2025
67 checks passed
@lmuntaner lmuntaner deleted the lm-improve-text-add-current-device-page branch January 22, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LXIF LXIF LXIF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @LXIF