Use devices' origin in add new device from recovery wizard #2808
+77
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UX: In the video you can see how a user that has one device registered in ic0.app logs in internetcomputer.org but then registers the new device in ic0.app instead of the current origin internetcomputer.org. Screen.Recording.2025-01-22.at.11.55.54.mov |
|
@sea-snake @LXIF please review |
sea-snake
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid bad UX by making sure that new devices are registered in the same origin as all the other devices.
In this PR, add this functionality in the recoveryWizard flow. See screenshot.
Changes
lookupCredentialscall tolookupAllbecause theoriginis necessary.Tests
lookupAll.🟡 Some screens were changed