Clean up cancelled RP IDs if no filtered credentials #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this fix, the user would get stuck, being sent to an error page until they clean up the browser storage. New UX: Screen.Recording.2025-01-28.at.16.18.53.mov |
|
@sea-snake please review |
sea-snake
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were adding domains as cancelled when the user closed the webauthn modal. We were assuming that was because the RP ID was incorrect.
However, there is the edge case that the RP ID is correct and the user cancelled manually. We can't differentiate both cancels.
In this PR, we clean up the cancelled RP IDs if there are no credentials for the remaining origins.
Changes
findWebAuthnRpIdto clean up the persisted storage and the local variables.Tests
🟡 Some screens were changed