doc: add notes to Timer.mo
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
commented
Jan 20, 2025
ggreif
force-pushed
the
gabor/timer-notes
branch
from
7f2e7eb to
bd64161
Compare
ggreif
commented
Jan 21, 2025
as Timo remarked, these may be misinterpreted by users, and constructing a case where `job` would have undesired side-effects proved very difficult in our experiments: see the thread around https://dfinity.slack.com/archives/CPL67E7MX/p1737461532661639?thread_ts=1736347600.078339&cid=CPL67E7MX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the notes in line with what the Motoko
docs/md/Timer.mdis.Basically also reverts #682.
Plus a few tweaks.