Get rid of Word types #2309
Merged
Get rid of Word types #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the produced WebAssembly code. |
nomeata
added a commit
to dfinity/motoko-base
that referenced
this pull request
Feb 5, 2021
the bit operations are now available on `Nat8`, `Int8`, etc. Goes along with dfinity/motoko#2309
|
Nice, CI is green just in time for the weekend. Not quite ready yet, that’s a good point to stop. |
|
Enjoy reviewing this beast… :-) |
rossberg
approved these changes
Apr 14, 2021
| val rotl : t -> t -> t | ||
| val rotr : t -> t -> t | ||
|
|
||
| val wrapping_of_big_int : Big_int.big_int -> t | ||
|
|
||
| val wrapping_neg : t -> t |
There was a problem hiding this comment.
Hm, should we perhaps provide unary -% now?
There was a problem hiding this comment.
Is it worth it? People can write 0 -% x
There was a problem hiding this comment.
Sure, but the same is true for regular negation, yet we provide it.
Just did, nothing worrying left (still plenty of |
|
Oh, I still need an approval for dfinity/motoko-base#214 to get this in. |
nomeata
added a commit
to dfinity/motoko-base
that referenced
this pull request
Apr 14, 2021
the bit operations are now available on `Nat8`, `Int8`, etc. goes along with dfinity/motoko#2309
|
done done done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes all traces of
Wordfrom the code, and thus concludes #2363.