Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: drun test for pattern-based imports #3081

Merged
merged 59 commits into from
Jan 28, 2022
Merged

test: drun test for pattern-based imports #3081

merged 59 commits into from
Jan 28, 2022

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Jan 28, 2022 •
edited
Loading

Additional test for #3076 (testing wasm execution on IC)

ggreif added 30 commits January 27, 2022 16:10
@ggreif
first shot at #2354
b46e72a
@ggreif
add test
e6e9915 
mostly failing now
@ggreif
improve a bit
67500bf
@ggreif
unit grooming
2d40582
@ggreif
cleaner
1556274
@ggreif
resolve the type error at the access site
3b120ee 
and push it into the module
@ggreif
resolve the module vs. field of module ambiguity
bcf3fcb 
doesn't pass IR checker yet
@ggreif
thread the module note through
59efd68
@ggreif
clean up
957f912
@ggreif
get the module VarE's type right
a1ee29c
@ggreif
cleanup
91c3708
@ggreif
make it 'import' <pat_nullary> '='? <text>
8d7fb3c
@ggreif
pointless
8fe6866
@ggreif
also pointless
ddcef0f
@ggreif
Update src/mo_frontend/parser.mly
f581947
@ggreif
capture the entire pattern
0eff5af 
now we get the best desugaring:
``` scheme
(LetD (ObjP (cons (VarP cons)) (nil (VarP nil))) (VarE file$lib/ListM.mo))
```
@ggreif
cleanups
999d654
@ggreif
make comp_unit_of_prog linear-time
c32448f
@ggreif
Revert "pointless"
58c629c 
This reverts commit 8fe6866.
@ggreif
Revert "also pointless"
ad314b7 
This reverts commit ddcef0f.
@ggreif
use modern syntax
2e9df25
@ggreif
fix repl tests
7293902
@ggreif
a few dodgy imports
93dcc88
@ggreif
accept
1a0a069
@ggreif
more failure modes
e72ce22
@ggreif
ignore explicit imports for now
d43c7ab
@ggreif
ocamlformat
3669465
@ggreif
mention explicit imports
6efb5f6
@ggreif
typo
b109d6d
@ggreif
teach IR typechecker to reject refutable import patterns
4c94e00
ggreif and others added 17 commits January 28, 2022 15:49
crusso
crusso commented Jan 28, 2022
View reviewed changes
@crusso crusso requested a review from ggreif January 28, 2022 22:46
@crusso crusso mentioned this pull request Jan 28, 2022
Merged
@ggreif ggreif changed the base branch from gabor/deconstruct-import to master January 28, 2022 23:05
ggreif
ggreif approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have any doubts!

@ggreif
Copy link
Contributor

ggreif commented Jan 28, 2022 via email

@crusso crusso added the automerge-squash When ready, merge (using squash) label Jan 28, 2022
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

Comparing from 09dcba8 to 1ded74a:
The produced WebAssembly code seems to be completely unchanged.

@mergify mergify bot merged commit b03bb7a into master Jan 28, 2022
@mergify mergify bot deleted the claudio/deconstruct-import branch January 28, 2022 23:49
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusso @ggreif