Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3121 #3123

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Fix #3121 #3123

merged 3 commits into from
Feb 24, 2022

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 24, 2022 •
edited
Loading

Product patterns like ObjP should be allowed to be static (side-effect-free when matching in CBV) so allow them also. Analogous to TupP.

Fixes #3121.

@ggreif ggreif requested a review from nomeata February 24, 2022 10:27
nomeata
nomeata reviewed Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename triv to pat maybe?

@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Feb 24, 2022
@ggreif ggreif requested a review from nomeata February 24, 2022 10:52
@github-actions
Copy link

github-actions bot commented Feb 24, 2022 •
edited
Loading

Comparing from ab57044 to 799d31a:
In terms of gas, no changes are observed in 3 tests.
In terms of size, no changes are observed in 3 tests.

@mergify mergify bot merged commit 220d362 into master Feb 24, 2022
@mergify mergify bot deleted the gabor/fix-3121 branch February 24, 2022 11:40
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selective Field Import
2 participants
@ggreif @nomeata