Skip to content

Commit

Permalink
Change schedule day for sns_aggregator candid workflow (#4940)
Browse files Browse the repository at this point in the history
# Motivation

We have 2 workflows that update candid (for
[proposals](https://github.com/dfinity/nns-dapp/blob/main/.github/workflows/update-proposals.yml)
and
[sns_aggregator](https://github.com/dfinity/nns-dapp/blob/main/.github/workflows/update-aggregator.yml)).
They update [adjacent
fields](https://github.com/dfinity/nns-dapp/blob/c2459e808ae46e54c58580a44ce2b26a3d8cb568/dfx.json#L391-L392)
in dfx.json, which make their PRs conflict, requiring manual
intervention.

# Changes

Run the `update-aggregator.yml` workflow on Tuesday instead of Monday to
avoid conflicts between simultaneous PRs.

# Tests

not tested

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
  • Loading branch information
dskloetd authored May 27, 2024
1 parent c2459e8 commit 22f22bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/update-aggregator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: Update sns_aggregator candid bindings
on:
schedule:
# Check for updates on candid interface for the aggregator every monday at 3:30am.
- cron: '30 3 * * MON'
- cron: '30 3 * * TUE'
workflow_dispatch:
push:
branches:
Expand Down

0 comments on commit 22f22bc

Please sign in to comment.