Skip to content

Commit

Permalink
NNS1-3092: Enable ENABLE_NEURONS_TABLE feature flag (#5065)
Browse files Browse the repository at this point in the history
# Motivation

The neurons table is now good enough to replace the card grid.
We'll continue iterating to make it better.

# Changes

1. Enabled `ENABLE_NEURONS_TABLE` by default.
2. Ran `scripts/nns-dapp/test-config --update`.

# Tests

CI passes

# Todos

- [x] Add entry to changelog (if necessary).
  • Loading branch information
dskloetd authored Jun 19, 2024
1 parent 14dc87e commit 397c607
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-Nns-Dapp-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ proposal is successful, the changes it released will be moved from this file to

#### Changed

* Display neurons in a table instead of a grid of cards.
* Removed the gap between identifier and copy button.

#### Deprecated
Expand Down
2 changes: 1 addition & 1 deletion dfx.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@
"ENABLE_CKBTC": true,
"ENABLE_CKTESTBTC": false,
"ENABLE_ACTIONABLE_TAB": true,
"ENABLE_NEURONS_TABLE": false,
"ENABLE_NEURONS_TABLE": true,
"ENABLE_CKUSDC": true
}
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/nns-dapp/test-config-assets/app/arg.did
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
record{ 0="CKUSDC_LEDGER_CANISTER_ID"; 1="xevnm-gaaaa-aaaar-qafnq-cai" };
record{ 0="CYCLES_MINTING_CANISTER_ID"; 1="rkp4c-7iaaa-aaaaa-aaaca-cai" };
record{ 0="DFX_NETWORK"; 1="app" };
record{ 0="FEATURE_FLAGS"; 1="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":false}" };
record{ 0="FEATURE_FLAGS"; 1="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":true}" };
record{ 0="FETCH_ROOT_KEY"; 1="false" };
record{ 0="GOVERNANCE_CANISTER_ID"; 1="rrkah-fqaaa-aaaaa-aaaaq-cai" };
record{ 0="HOST"; 1="https://icp-api.io" };
Expand Down
2 changes: 1 addition & 1 deletion scripts/nns-dapp/test-config-assets/app/env
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ VITE_LEDGER_CANISTER_ID=ryjl3-tyaaa-aaaaa-aaaba-cai
VITE_INDEX_CANISTER_ID=qhbym-qaaaa-aaaaa-aaafq-cai
VITE_OWN_CANISTER_ID=xnjld-hqaaa-aaaal-qb56q-cai
VITE_FETCH_ROOT_KEY=false
VITE_FEATURE_FLAGS="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":false}"
VITE_FEATURE_FLAGS="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":true}"
VITE_HOST=https://icp-api.io
VITE_IDENTITY_SERVICE_URL=https://identity.internetcomputer.org/
VITE_AGGREGATOR_CANISTER_URL=https://otgyv-wyaaa-aaaak-qcgba-cai.icp0.io
Expand Down
2 changes: 1 addition & 1 deletion scripts/nns-dapp/test-config-assets/mainnet/arg.did
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
record{ 0="CKUSDC_LEDGER_CANISTER_ID"; 1="xevnm-gaaaa-aaaar-qafnq-cai" };
record{ 0="CYCLES_MINTING_CANISTER_ID"; 1="rkp4c-7iaaa-aaaaa-aaaca-cai" };
record{ 0="DFX_NETWORK"; 1="mainnet" };
record{ 0="FEATURE_FLAGS"; 1="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":false}" };
record{ 0="FEATURE_FLAGS"; 1="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":true}" };
record{ 0="FETCH_ROOT_KEY"; 1="false" };
record{ 0="GOVERNANCE_CANISTER_ID"; 1="rrkah-fqaaa-aaaaa-aaaaq-cai" };
record{ 0="HOST"; 1="https://icp-api.io" };
Expand Down
2 changes: 1 addition & 1 deletion scripts/nns-dapp/test-config-assets/mainnet/env
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ VITE_LEDGER_CANISTER_ID=ryjl3-tyaaa-aaaaa-aaaba-cai
VITE_INDEX_CANISTER_ID=qhbym-qaaaa-aaaaa-aaafq-cai
VITE_OWN_CANISTER_ID=qoctq-giaaa-aaaaa-aaaea-cai
VITE_FETCH_ROOT_KEY=false
VITE_FEATURE_FLAGS="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":false}"
VITE_FEATURE_FLAGS="{\"ENABLE_ACTIONABLE_TAB\":true,\"ENABLE_CKBTC\":true,\"ENABLE_CKTESTBTC\":false,\"ENABLE_CKUSDC\":true,\"ENABLE_NEURONS_TABLE\":true}"
VITE_HOST=https://icp-api.io
VITE_IDENTITY_SERVICE_URL=https://identity.internetcomputer.org/
VITE_AGGREGATOR_CANISTER_URL=https://3r4gx-wqaaa-aaaaq-aaaia-cai.icp0.io
Expand Down

0 comments on commit 397c607

Please sign in to comment.