-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disallow build warnings for Rust (#4703)
# Motivation Build warnings are distracting and confusing. There is one type of build warning that can start appearing without any changes in the code: future incompatibility. When there is a breaking change in a future version of a dependency, this will start causing build warnings without changes in the repository. We need to disable these warning in order to safely disallow any build warnings in Rust and prevent the introduction of new warnings. # Changes 1. Add `RUSTFLAGS="-D warnings"` in front of `cargo test` in CI to disallow build warning. 2. Disable the "future incompatibility" warning by adding a `config.toml` file. 3. Fix a warning by removing unused `use candid::types::number;` from `rs/backend/src/accounts_store/schema/proxy/tests.rs`. 4. Fix a warning by removing unused `schema_label` from `rs/backend/src/state/partitions.rs` # Tests CI passes # Todos - [x] Add entry to changelog (if necessary).
- Loading branch information
Showing
5 changed files
with
5 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[future-incompat-report] | ||
frequency = "never" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters