Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust version to 1.79.0 #5051

Closed
wants to merge 1 commit into from
Closed

Conversation

sa-github-api
Copy link
Collaborator

Motivation

A new verion of Rust is available.

Automated changes

  • Update Rust version.

Manual changes

  • Fix clippy lints (if necessary)
  • Write a changelog entry.

@sa-github-api sa-github-api requested a review from a team as a code owner June 14, 2024 03:31
@dskloetd dskloetd mentioned this pull request Jun 17, 2024
1 task
@dskloetd
Copy link
Contributor

Replaced by #5060

@dskloetd dskloetd closed this Jun 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 17, 2024
# Motivation

The automatic [Rust version
upgrade](#5051) failed because
of a [lint
error](https://github.com/dfinity/nns-dapp/actions/runs/9510216178/job/26214335680?pr=5051).

# Changes

1. Bump Rust to 1.79.0
2. Fix the lint error.

# Tests

`scripts/lint-rs` passes

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants