Draft: vp from network economics #6165
Draft
+729
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/nns-dapp into get-network-economics-parameters
mstrasinskis
commented
Jan 17, 2025
| <IconErrorOutline /> | ||
| </BannerIcon> | ||
| </Banner> | ||
| {#if nonNullish($startReducingVotingPowerAfterSecondsStore)} |
There was a problem hiding this comment.
| class="description" | ||
| class:negative={isLosingRewards || isLosingRewardsSoon} | ||
| data-tid="state-description" | ||
| {#if nonNullish($startReducingVotingPowerAfterSecondsStore) && nonNullish($clearFollowingAfterSecondsStore)} |
There was a problem hiding this comment.
|
|
||
| let isModalVisible = false; | ||
| </script> | ||
|
|
||
| <TestIdWrapper testId="losing-rewards-banner-component"> | ||
| {#if nonNullish(mostInactiveNeuron)} | ||
| <Banner title={getTitle(mostInactiveNeuron)} {text}> | ||
| {#if nonNullish(mostInactiveNeuron) && nonNullish($startReducingVotingPowerAfterSecondsStore)} |
There was a problem hiding this comment.
| if (isNeuronLosingRewards(neuron)) { | ||
| // Skip the "missing rewards" tag when voting power economics not available | ||
| if ( | ||
| nonNullish(startReducingVotingPowerAfterSeconds) && |
There was a problem hiding this comment.
| }: { | ||
| neuron: NeuronInfo; | ||
| startReducingVotingPowerAfterSeconds: bigint | undefined; | ||
| clearFollowingAfterSeconds: bigint | undefined; |
There was a problem hiding this comment.
| * e.g. "Neuron will start losing rewards in 30 days" | ||
| * If the voting power economics are not available, | ||
| * we assume that the neuron is not losing rewards. */ | ||
| export const shouldDisplayRewardLossNotification = ({ |
There was a problem hiding this comment.
| secondsUntilLosingRewards(neuron) <= 0; | ||
| /** If the voting power economics are not available, | ||
| * we assume that the neuron is not losing rewards. */ | ||
| export const isNeuronLosingRewards = ({ |
There was a problem hiding this comment.
…/nns-dapp into get-network-economics-parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Tests
Todos