Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(portfolio): update token cards with new icons #6194

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat(portfolio): update token cards with new icons #6194

merged 2 commits into from
Jan 21, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 20, 2025 •
edited
Loading

Motivation

We have new icons for the Portfolio page:

Screenshot 2025-01-20 at 16 55 59 Screenshot 2025-01-20 at 16 56 15 Screenshot 2025-01-20 at 17 22 26

Changes

  • Updated the icons in the header of the HeldTokensCard and StakedTokensCard.
  • Updated the icon in the LoginCard.

Tests

  • Tests should pass as before

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title new icons feat(portfolio): add new card icons Jan 20, 2025
@yhabib yhabib marked this pull request as ready for review January 20, 2025 13:27
@yhabib yhabib requested a review from a team as a code owner January 20, 2025 13:27
@yhabib yhabib changed the title feat(portfolio): add new card icons feat(portfolio): update token cards with new icons Jan 20, 2025
@yhabib
Copy link
Contributor Author

yhabib commented Jan 20, 2025

Thanks for the feedback, @dskloetd.

@yhabib yhabib force-pushed the nns1-3538/new-icons branch from 6c5e3d5 to ee2ed97 Compare January 20, 2025 16:24
mstrasinskis
mstrasinskis approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@yhabib yhabib added this pull request to the merge queue Jan 20, 2025
@yhabib yhabib removed this pull request from the merge queue due to a manual request Jan 20, 2025
@yhabib yhabib added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 7056fbf Jan 21, 2025
32 checks passed
@yhabib yhabib deleted the nns1-3538/new-icons branch January 21, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis