Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat: Add additional logging from bitcoin canister in replica." #2342

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

ericswanson-dfinity
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity commented Jul 13, 2022

Reverts #2318

This change is preventing us from updating to the latest hotfix replica (example: #2341 and build failure). Will re-incorporate this change when future replica releases support it.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner July 13, 2022 17:50
@ericswanson-dfinity ericswanson-dfinity changed the title Revert "feat: Add additional logging from bitcoin canister in replica." chore: Revert "feat: Add additional logging from bitcoin canister in replica." Jul 13, 2022
@mergify mergify bot merged commit 9541a90 into master Jul 13, 2022
@mergify mergify bot deleted the revert-2318-ielashi/bitcoin_debug_overrides branch July 13, 2022 18:21
ericswanson-dfinity added a commit that referenced this pull request Jul 13, 2022
mergify bot pushed a commit that referenced this pull request Jul 16, 2022
Tests for this PR will pass after we integrate a replica (ic-starter) that supports this 

Reverts #2342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants