Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update frontend templates #4105

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

chore: update frontend templates #4105

wants to merge 29 commits into from

Conversation

raymondk
Copy link
Contributor

@raymondk raymondk commented Feb 8, 2025

Description

New design for the frontend templates used by dfx new

Fixes # SDK-1896

Replaces: #4003

@raymondk raymondk requested a review from a team as a code owner February 8, 2025 03:08
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR carries over a defect from the original PR: it appears to copy/paste, possibly with modifications, the individual headers in the standard security policy into the .ic-assets.json5 files in the various project templates.

This defeats the purpose of the security policy settings, because it means that developers who use these templates will have to manually propagate future changes to the standard security policy headers into their projects' configuration files.

If the project templates do actually need different headers than those in the standard security policy, then this PR should introduce some description of what those differences are and the reasoning behind them.

Once that rationale is better understood, we can evaluate whether and how to make those changes in a way that is better from a DRY perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants