This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
feat: Switch to k256 (and pkcs8) #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per FOLLOW-730, libsecp256k1 has a few problems. This replaces it with k256, which is also the library that ic-agent uses. tiny-hderive is also replaced with bip32, as tiny-hderive is GPL-licensed. Finally, k256's support for encrypted / pkcs8 pem files is utilized, and the default storage format for pem files switched to pkcs8, in preparation for FOLLOW-728. Unfortunately the last requested change, [email protected], must be fixed upstream.