This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
feat: encrypted identities by default #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per FOLLOW-728, quill currently stores sensitive data to disk as plaintext. This PR makes identities password-protected by default, using pkcs8's built-in scrypt encryption mechanism. It additionally stops storing seed phrases in txt files unless the user explicitly requests it, stops using seed phrases as a primary key at all, overhauls the internal representation of keys to be ic-agent identities instead of pem files (to facilitate only decrypting once per command) and fixes a few other things I found along the way like file paths being stored as strings.