level 0 phpstan

dfo-osdt · Feb 22, 2023 · 3ac7463 · 3ac7463
1 parent ca66fc5
commit 3ac7463
Show file tree

Hide file tree

Showing 8 changed files with 186 additions and 55 deletions.
diff --git a/_ide_helper_models.php b/_ide_helper_models.php
diff --git a/app/Http/Controllers/ManuscriptRecordFundingSourceController.php b/app/Http/Controllers/ManuscriptRecordFundingSourceController.php
@@ -38,7 +38,7 @@ public function store(ManuscriptRecord $manuscriptRecord, Request $request): Jso
             'description' => 'nullable|string|max:1500',
         ]);
 
-        $fundingSource = FundingSource::make([
+        $fundingSource = new FundingSource([
             'funder_id' => $validated['funder_id'],
             'title' => $validated['title'],
             'description' => $validated['description'],

diff --git a/app/Http/Controllers/PublicationController.php b/app/Http/Controllers/PublicationController.php
@@ -59,7 +59,7 @@ public function store(Request $request): JsonResource
         ]);
 
         // create the publication
-        $publication = Publication::make($validated);
+        $publication = new Publication($validated);
         $publication->user_id = $request->user()->id;
         $publication->save();
 

diff --git a/app/Http/Controllers/PublicationFundingSourceController.php b/app/Http/Controllers/PublicationFundingSourceController.php
@@ -38,7 +38,7 @@ public function store(Publication $publication, Request $request): JsonResource
             'description' => 'nullable|string|max:1500',
         ]);
 
-        $fundingSource = FundingSource::make([
+        $fundingSource = new FundingSource([
             'funder_id' => $validated['funder_id'],
             'title' => $validated['title'],
             'description' => $validated['description'],

diff --git a/app/Models/Invitation.php b/app/Models/Invitation.php
@@ -4,6 +4,7 @@
 
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Str;
 use URL;
 
@@ -30,15 +31,15 @@ class Invitation extends Model
     /**
      * Get the user that owns the invitation.
      */
-    public function user()
+    public function user(): BelongsTo
     {
         return $this->belongsTo(User::class);
     }
 
     /**
      * Get the user that invited the user.
      */
-    public function invitedByUser()
+    public function invitedByUser(): BelongsTo
     {
         return $this->belongsTo(User::class, 'invited_by');
     }

diff --git a/composer.json b/composer.json
@@ -32,6 +32,7 @@
         "laravel/sail": "^1.18.1",
         "mockery/mockery": "^1.5.1",
         "nunomaduro/collision": "^6.4.0",
+        "nunomaduro/larastan": "^2.0",
         "orangehill/iseed": "^3.0.2",
         "pestphp/pest": "^1.22.3",
         "pestphp/pest-plugin-laravel": "^1.4",

diff --git a/composer.lock b/composer.lock
diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,19 @@
+includes:
+    - ./vendor/nunomaduro/larastan/extension.neon
+
+parameters:
+
+    paths:
+        - app
+        - database
+
+    # Level 9 is the highest level
+    level: 1
+
+#    ignoreErrors:
+#        - '#PHPDoc tag @var#'
+#
+#    excludePaths:
+#        - ./*/*/FileToBeExcluded.php
+#
+#    checkMissingIterableValueType: false