Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes across multiple files, focusing on code cleanup, dependency updates, and minor logic improvements. Below are the most important changes grouped by their themes:
Code Cleanup and Formatting:
app/Models/Author.php
: Improved formatting in thehasValidOrcidCredentials
method for better readability.app/Policies/AuthorEmploymentPolicy.php
: Enhanced readability by adding braces to conditional statements. [1] [2]Dependency Updates:
composer.json
: Updatedlaravel/prompts
from version^0.1.21
to^0.3.1
.package.json
: Updated@types/node
from version^22.8.7
to^22.9.0
.pnpm-lock.yaml
: Updated multiple dependencies including@types/node
,@typescript-eslint
, andelectron-to-chromium
. [1] [2] [3] [4] [5] [6] [7]Minor Logic Improvements:
app/Http/Controllers/AuthorController.php
: Added a newline for better code separation in thestore
method.app/Jobs/SyncAuthorEmploymentWithOrcid.php
: Added newlines for better readability in multiple methods. [1] [2] [3]Miscellaneous:
app/Actions/Expertise/SyncExpertiseWithScience.php
: Corrected a trailing comma in thetermsToRemove
array.app/Models/AuthorEmployment.php
: Added a newline for consistency in the use of traits.