Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

795 add peer reviewers to internal mrfs #826

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

vincentauger
Copy link
Member

This pull request introduces significant changes to the manuscript peer review functionality, including the addition of new models, controllers, policies, and resources. The key updates are the implementation of the ManuscriptPeerReviewer model and its associated controller, policies, and resources, as well as updates to factories and seeders to support the new functionality.

Key Changes:

New Models and Enums:

  • Added ManuscriptPeerReviewer model to manage peer reviewers for manuscripts. This includes attributes for manuscript_record_id, author_id, review_date, role, and type with appropriate relationships and casts.
  • Introduced PeerReviewRole and PeerReviewType enums to categorize the roles and types of peer reviews. [1] [2]

Controllers and Policies:

  • Created ManuscriptPeerReviewerController to handle CRUD operations for manuscript peer reviewers, including validation and authorization checks.
  • Implemented ManuscriptPeerReviewerPolicy to manage permissions for viewing, updating, and deleting peer reviewers.

Resources and Factories:

  • Added ManuscriptPeerReviewerResource to format the peer reviewer data for API responses, including authorization checks for update and delete actions.
  • Updated ManuscriptPeerReviewerFactory to generate test data for peer reviewers.

Database and Seeders:

  • Created a migration to add the manuscript_peer_reviewers table with necessary foreign keys and attributes.
  • Updated ManuscriptRecordFactory and LocalTestDataSeeder to include peer reviewers in the generated manuscript records. [1] [2]

These changes collectively enhance the manuscript management system by adding robust support for managing peer reviewers, ensuring proper validation, authorization, and data handling throughout the application.

closes #795

@vincentauger vincentauger linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link

✔️ All Checks Passed!

🛡️ 0 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

@vincentauger vincentauger merged commit 528ea78 into main Nov 18, 2024
4 checks passed
@vincentauger vincentauger deleted the 795-add-peer-reviewers-to-internal-mrfs branch November 18, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Peer-Reviewers to Internal MRFS
1 participant