Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(librarium): updated roles edit and filter to respond dynamically to a change in roles #841

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

MathewEm
Copy link
Collaborator

This pull request includes updates to the Librarium UserResource file to decouple the Roles filter and edit methods. A general tidy of the code was done too.

Frontend Changes

  • The View Table filter now displays available roles in a drop-down, mono-Select component.
  • The Edit User form now displays available roles in a two-column Checkbox component.
  • The search bar above the Roles column in the View Table has been removed.
  • You can now search by First Name, Last Name, Email, or Role in the global search bar.

Backend Changes

  • New roles which have not been assigned a badge color will default to Blue.
  • The Roles filter has been changed from Checkbox to Select. This allows for the Select option to automatically change when there is a change to the Roles table.
  • Unused code has been removed.

Copy link

⚠️ 1 Checks Failed!

🛡️ 1 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

Copy link
Member

@vincentauger vincentauger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - 🚀

@vincentauger vincentauger merged commit ae4d83b into main Nov 28, 2024
3 of 4 checks passed
@vincentauger vincentauger deleted the librarium-edit-role branch December 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants