Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author progress #865

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Author progress #865

merged 9 commits into from
Dec 12, 2024

Conversation

vincentauger
Copy link
Member

This pull request includes various enhancements and fixes across multiple files, focusing on validation improvements, resource management, and dependency updates. The most important changes include adding new validation rules, updating resource relationships, and refining the handling of manuscript records.

Validation Improvements:

  • Added ValidListItems validation rule to ensure list items are valid in AuthorController (app/Http/Controllers/AuthorController.php).

Resource Management:

  • Introduced ManuscriptRecordMetadataResource to provide metadata for manuscript records (app/Http/Resources/ManuscriptRecordMetadataResource.php).
  • Updated AuthorResource to include publications when loaded (app/Http/Resources/AuthorResource.php).
  • Added publications relationship to Author model to fetch published publications (app/Models/Author.php).

Manuscript Records Handling:

  • Added metadata method to ManuscriptRecordController to return basic metadata (app/Http/Controllers/ManuscriptRecordController.php).
  • Refined defaultResource and loadPolicyRelationships methods to avoid N+1 queries (app/Http/Controllers/ManuscriptRecordController.php).

Dependency Updates:

  • Updated @types/node and other dependencies in package.json and pnpm-lock.yaml to their latest versions (package.json, pnpm-lock.yaml). [1] [2] [3] [4] [5] [6] [7]

Miscellaneous:

  • Improved ORCID API health check URL and timeout settings in AppServiceProvider (app/Providers/AppServiceProvider.php).
  • Enhanced deleteEmploymentRecordInOrcid method to handle cases where the record was never created in ORCID (app/Jobs/SyncAuthorEmploymentWithOrcid.php).

Copy link

✔️ All Checks Passed!

🛡️ 0 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

@vincentauger vincentauger merged commit 67f8e9f into main Dec 12, 2024
4 checks passed
@vincentauger vincentauger deleted the author-progress branch December 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant