Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(librarium): Announcement management page #896

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

MathewEm
Copy link
Collaborator

@MathewEm MathewEm commented Jan 7, 2025

This pull request adds AnnouncementResources, and associated Announcement page modification files to the Librarium. These additions allow for announcements to be created, edited, and deleted as per #893 .

Frontend Changes

  • Announcement tab now present in Librarium dashboard
  • Announcement index page displays tables containing Past, Current, and Upcoming announcements with creation, edit, and deletion buttons
  • Announcement index page allows for viewing or editing of full details of an announcements in a popup window
  • Announcement creation page contains form with required attributes for the creation of an announcement

Backend Changes

  • AnnouncementResources.php implements creation form with validation and viewable table
  • The Announcement model now has title, text, and duration date attributes added to the $fillable array for mass assignment by Librarium
  • CreateAnnouncement.php adds a T23:59:59 time-element to end_at to force all announcements to end at end-of-day UTC
  • The EditAction method adds a T23:59:59 time-element to end_at if configured to force announcement to end at end-of-day UTC

@MathewEm MathewEm requested a review from vincentauger January 7, 2025 17:32
@MathewEm MathewEm self-assigned this Jan 7, 2025
Copy link

⚠️ 1 Checks Failed!

🛡️ 1 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

Copy link

✔️ All Checks Passed!

🛡️ 0 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

Copy link
Member

@vincentauger vincentauger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vincentauger vincentauger merged commit f5760b6 into main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants