Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(journal): increased journal list size #911

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

MathewEm
Copy link
Collaborator

What

This PR updates the JournalSelect.vue component to enhance the journal filtering functionality and address a broken hyperlink in both EN and FR locales.

Why

  1. The journal/series select list previously displayed an incomplete set of DFO series when filtering by ISN 1488-, which could negatively impact user experience when creating publication records for already published manuscripts.
  2. The hyperlink to the Crown Copyright policy redirected to a 404 page, as DFO has updated the URL.

Frontend Changes

  • Increased the size of the journal/series select list to display 12 records (up from 10).
  • Updated the hyperlink to the Crown Copyright page to the correct URL: DFO - Crown Copyright.

Backend Changes

  • Modified the filterJournals Spatie Query to .paginate(1,12), ensuring all and only DFO series are included when filtering by ISN 1488-.

@MathewEm MathewEm added Type: Bug Something isn't working Priority: Low labels Jan 24, 2025
@MathewEm MathewEm self-assigned this Jan 24, 2025
Copy link

⚠️ 1 Checks Failed!

🛡️ 1 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

Copy link
Member

@vincentauger vincentauger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! Good catch on the links.

@vincentauger vincentauger merged commit d0676bb into main Jan 24, 2025
3 of 4 checks passed
@vincentauger vincentauger deleted the journal-list-increase branch January 24, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants