-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Actinides. #48
Conversation
Thanks for sharing. Looks good to me. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 50.15% 48.63% -1.53%
==========================================
Files 34 34
Lines 3776 3707 -69
Branches 1601 1518 -83
==========================================
- Hits 1894 1803 -91
- Misses 1206 1207 +1
- Partials 676 697 +21 ☔ View full report in Codecov by Sentry. |
…: Statement too long".
Potentially fixed the weird build check error of build (ubuntu-20.04, meson, debug, intel, 2021.2.0) by shortening the lines in the reference file. |
The build (ubuntu-20.04, meson, debug, intel, 2021.2.0) still fails, even after lines were truncated. I am clueless as to why this is happening. Does anyone else have any insights into the possible reasons for this occurrence? |
Can't say why the Intel build is failing, there have been issues with the array constructors and number of continuation lines before. It would be mandatory to fix those issues before merging this patch. |
Fixed the issue @awvwgk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now
Description
Added actinides support to the Fortran version, following the Torch autodiff DFT-D3 implementation by FreeSoulIG.
Changes Made
Crosschecked and validated results from both implementations to ensure accuracy. The test suite successfully completed without any errors.