PDO: Support for PDO::ERRMODE_EXCEPTION (PHP8)

[dakujem]

• new feature, no existing code will break (full bc)

I added support for PDO in PDO::ERRMODE_EXCEPTION error mode using a single try-catch block.

👉 Since in PHP 8 PDO::ERRMODE_EXCEPTION is the default error mode!

[dg]

I think it would be best to do a BC break and add support (only) for PDO::ERRMODE_EXCEPTION in dibi 5.0 and keep version 4.2 as it is. What do you think?

[dakujem]

Since it is backwards compatible, I see no reason not to include it in v4. It can be the default in v5.

[dg]

I think it's a more complicated matter, see #293

[dakujem]

I don't see how that's related. I do not need dibi to create me an exception. All I want is to run PDO connection in exception mode.

This PR is 100% backward compatible with existing code and does not cause any breaks. It only allows PDO users to enable connection mode that throws exceptions on errors (which is what Dibi essentially does for other connection types).

Without this, users are not even allowed to connect using EXCEPTION mode.

What #293 is trying to solve is broken WARNING mode handling. That's not the concern of this PR.

[dg]

But exceptions also throw all other PDO methods, not just query.

[dakujem]

And the problem is that they would not be caught by Dibi?
I think users would be better off with native PDO exceptions than not being able to use the exception mode.

[dakujem]

I don't fully understand why this useful feature is still not integrated after 4 years.

Came across a note in my code that works around this shortcoming, just to see nothing has been done here nor in #393 ... now there is Dibi v5 already out which only runs on PHP 8 and that means in default settings this PDO driver will simply not work.

See here: https://www.php.net/manual/en/pdo.error-handling.php

Because of the private-access props in the driver, there is no way to just tweak the piece of code in the constructor, so one needs to copy the whole driver. 🤦‍♂️

Seems like releasing a separate package with just the improved PDO driver is the way to go.