Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report addons with different cachekey but same version & adding summary to output #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

step2yeung
Copy link

This PR fixes a bug and adds a new summary section to the output

  1. Some addons may return a custom cachekey, in my example, the addon returns a different cachekey if an addon is declared from the root vs as child's dependent. ECAG(Ember-cli-addon-guard) reported that addon as a failure, when the version is actually the same. Fix was to have ECAG to also check for version.
  2. Having a summary section on the top of the output helps with parsing all the information easily.
    eg:
Summary
Number of addons with multiple versions: 16

@embroider/macros: [0.36.0 , 0.24.1]
ember-get-config: [0.2.4 , 0.3.0]
ember-lifeline: [4.1.5 , 3.1.1 , 5.1.0 , 6.0.1]
ember-test-selectors: [5.0.0 , 3.0.0]
ember-batcher: [3.0.0 , 4.0.1]

Details
ember-cli-addon-guard determined that your application is dependent on multiple versions of the following run-time addons:

@embroider/macros
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant