Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use new rule format #20

Merged
merged 1 commit into from
Dec 29, 2018
Merged

Conversation

macklinu
Copy link
Contributor

This PR refactors the codebase to use ESLint's "new rule format". This refactor was automated by the eslint-transforms tool. My steps for refactoring:

  • npx eslint-transforms new-rule-format rules/
  • npx eslint . --fix

I haven't seen any documentation from ESLint in terms of the old rule format being unsupported, but I wanted to open this PR to keep the codebase up-to-date.

There are a lot of whitespace changes in this PR, so appending ?w=1 to the PR URL will help make this PR easier to review. Thanks, let me know if you have any questions. 😃

@dgraham dgraham merged commit 585a852 into dgraham:master Dec 29, 2018
dgraham added a commit that referenced this pull request Dec 29, 2018
Matches the development dependency version to avoid older versions of
eslint not recognizing the new rules format from #20.
@macklinu macklinu deleted the new-rule-format branch March 11, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants