Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring 2FA #39

Closed
adavison007 opened this issue Jun 23, 2019 · 19 comments
Closed

Ring 2FA #39

adavison007 opened this issue Jun 23, 2019 · 19 comments
Labels
enhancement New feature or request

Comments

@adavison007
Copy link

Does this work if you have the ring 2fa turned on? I was using a different ring plugin until last week, I turned on Ring 2FA and then the plugin could not authenticate. Please can you advise if yours works with the Ring 2FA enabled before I install, thanks in advance...

@dgreif dgreif added the enhancement New feature or request label Jun 23, 2019
@dgreif
Copy link
Owner

dgreif commented Jun 23, 2019

See #26 for previous discussion. It might be reasonably doable depending on how refresh tokens work. I'll look into it when I have time, but can't make any promises on a timeline. I think 2FA is great and would like to get it implemented at some point.

dgreif added a commit that referenced this issue Jul 7, 2019
@dgreif
Copy link
Owner

dgreif commented Jul 7, 2019

@adavison007 @d0n4v4nb3ck3r I have added 2fa support for the api and the homebridge plugin. See https://github.com/dgreif/ring/tree/master/homebridge#2-factor-authentication-2fa for setup instructions. I plan to add another method to get a refreshToken at some point, but it should be functional the way I have it set up now. Let me know how it works for you!

@adavison007
Copy link
Author

Thank you for this, I’m running hoobs, so I guess I should see the request if I open the terminal? Or in logs?

@BradMcGonigle
Copy link

@adavison007 looking at the Hoobs logs won't work because your need to enter the two factor code that Ring sends via SMS when homebridge starts up to get the refreshToken.

I'm only vaguely familiar with hoobs but it probably starts homebridge on boot so there is not method for entering the two factor SMS code that Ring sends. You'd have to start homebridge manually in console to get the prompt to enter it I believe.

@adavison007
Copy link
Author

@adavison007 looking at the Hoobs logs won't work because your need to enter the two factor code that Ring sends via SMS when homebridge starts up to get the refreshToken.

I'm only vaguely familiar with hoobs but it probably starts homebridge on boot so there is not method for entering the two factor SMS code that Ring sends. You'd have to start homebridge manually in console to get the prompt to enter it I believe.

Bugger!!! Just tried this and nothing appears in logs or terminal in hoobs.... everything from ring stopped working, so had to turn off 2FA again... let me know if you find an alternative option? I've attached a screen shot of the hoobs start up config?
image

@adavison007
Copy link
Author

@BradMcGonigle I can separately ssh into hoobs, if that helps?

@dgreif
Copy link
Owner

dgreif commented Jul 8, 2019

Sorry for the bad user experience on this. I got the main functionality working, but it could definitely be easier to get the refresh token. I’m planning to publish a cli tool to make it simple in the next few days. You would have to ssh in and run homebridge manually right now. The problem is that the prompt for the 2fa code can easily get lost in the rest of the homebridge output.

@adavison007
Copy link
Author

Sorry for the bad user experience on this. I got the main functionality working, but it could definitely be easier to get the refresh token. I’m planning to publish a cli tool to make it simple in the next few days. You would have to ssh in and run homebridge manually right now. The problem is that the prompt for the 2fa code can easily get lost in the rest of the homebridge output.

@BradMcGonigle Cool, let me know when you want me to test the CLI option, really appreciate the support on this. Then we need live stream for the cameras 🥇

@BradMcGonigle
Copy link

Sorry for the bad user experience on this. I got the main functionality working, but it could definitely be easier to get the refresh token. I’m planning to publish a cli tool to make it simple in the next few days. You would have to ssh in and run homebridge manually right now. The problem is that the prompt for the 2fa code can easily get lost in the rest of the homebridge output.

@dgreif please....thank you so much for your work on everything here. The community to is lucky to have fantastic contributors like yourself. I'm always impressed with the speed and quality of the updates/releases you've been putting out lately.

If you need help testing the cli tool, I'd be happy to help.

@donavanbecker
Copy link
Contributor

@dgreif 2fa works awesome!!! Thanks so much for implementing this! I wasn’t expecting it this soon. You are quick.

Sent with GitHawk

@adavison007
Copy link
Author

@dgreif Any news on the CLI command for 2FA? Sorry to chase, keen to use, massive thanks in advance.

@dgreif
Copy link
Owner

dgreif commented Jul 15, 2019

@adavison007 sorry for the lack of info. I'm almost done with the CLI, just working on how exactly I want to deploy it for use. I should have it released in the next couple days

@adavison007
Copy link
Author

@adavison007 sorry for the lack of info. I'm almost done with the CLI, just working on how exactly I want to deploy it for use. I should have it released in the next couple days

@dgreif Many thanks, let me know and I'll test straight away.

dgreif added a commit that referenced this issue Jul 16, 2019
@dgreif
Copy link
Owner

dgreif commented Jul 16, 2019

@adavison007 sorry for the long wait, but the ring-auth-cli has landed in v4.2.0. See https://github.com/dgreif/ring/wiki/Two-Factor-Auth for details on how to use it. Let me know how it works for you 😄

@BradMcGonigle
Copy link

@dgreif worked great for me. Awesome work!

@adavison007
Copy link
Author

@adavison007 sorry for the long wait, but the ring-auth-cli has landed in v4.2.0. See https://github.com/dgreif/ring/wiki/Two-Factor-Auth for details on how to use it. Let me know how it works for you 😄

@dgreif Awesome! I will try tonight when home, thanks in advance.

@donavanbecker
Copy link
Contributor

@dgreif works awesome!!

@adavison007
Copy link
Author

adavison007 commented Jul 17, 2019

@dgreif BOOM! You the man, works a dream (used CLI in hoobs web UI) @dgreif Just need to work out how to do the live video stream now :)

@dgreif
Copy link
Owner

dgreif commented Jul 17, 2019

Thanks @adavison007 and everyone else for your patience and testing on this!

@dgreif dgreif closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants