Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] changelog in Homebridge UI #86

Closed
ifeign opened this issue Jul 31, 2019 · 8 comments
Closed

[Feature request] changelog in Homebridge UI #86

ifeign opened this issue Jul 31, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@ifeign
Copy link

ifeign commented Jul 31, 2019

This plugin is amazing so I hate to ask more of you. I use several plugins that display the changelog within the config UI after updating.

Since your plugin is so frequently updated it would be beneficial to see these regular changes within Homebridge, saving a visit to github. It's also an opportunity to inform people about new major changes (updating 3.x to 4.x, your new wiki etc) and possibly reduce the number of people posting issues about things you've already addressed.

A great example of this is Homebridge-Neato. This plugin also has another really cool feature, the config schema, which allows users to create a perfectly formatted config by filling in forms and multiple choice options vs doing it all by hand.. but that's something for another time.

@dgreif dgreif added the enhancement New feature or request label Jul 31, 2019
@dgreif
Copy link
Owner

dgreif commented Jul 31, 2019

I manage all my packages directly with npm, not a GUI, so I didn't realize I was missing out on a way to communicate. Which specific config UI are you using (I think there are a few)? Looks like homebridge-neato puts their changelog in their GitHub releases, which is probably what the UI pulls from. That is pretty easy for me to add and a good practice to follow anyways. I'll try to get it done in the next week or two. Great suggestion!

As for the config file, it looks like this might be what generates the form: https://github.com/naofireblade/homebridge-neato/blob/master/config.schema.json. Where do you see that form show up?

@ifeign
Copy link
Author

ifeign commented Jul 31, 2019

Thanks for looking into this. I use Homebridge-Config-UI-X. Which I believe is the most widely used one. It's also packaged with HOOBS so we'll probably see a lot more of it now that HOOBS is gaining in popularity.

This is what the schema looks like
Screen Shot 2019-07-31 at 8 52 09 AM
Screen Shot 2019-07-31 at 8 52 19 AM

@ifeign ifeign closed this as completed Jul 31, 2019
@ifeign ifeign reopened this Jul 31, 2019
@ifeign
Copy link
Author

ifeign commented Jul 31, 2019

Here's a more detailed example of a config.schema.json https://github.com/oznu/homebridge-config-ui-x/blob/master/config.schema.json
Screen Shot 2019-07-31 at 1 47 01 PM

@benfysh
Copy link

benfysh commented Aug 1, 2019

There is also a developer guide in the Config UI X wiki

@ifeign
Copy link
Author

ifeign commented Aug 1, 2019

There is also a developer guide in the Config UI X wiki

@benfysh so much more useful than what I found. Idk how I missed this wiki page.

@dgreif
Copy link
Owner

dgreif commented Aug 1, 2019

@ifeign I really appreciate you suggesting this change. Anything that I can do to make it easier for users to get set up and update the plugin, I am happy to do! Here are some screenshots of the new features:

Release Notes

image

Changelog

image

Settings UI

image

Option Config

image

@dgreif dgreif closed this as completed Aug 1, 2019
@ifeign
Copy link
Author

ifeign commented Aug 1, 2019

Awesome work @dgreif. This makes it almost impossible to mess up when configuring the plugin, which is great for those newer to Homebridge (most of the Homebridge posts on Reddit are config.json formatting issues). You've created one of the most well-rounded Homebridge plugins out there!

@wondergit113
Copy link

@dgreif you are amazing. Seriously, the world will be a better place with more devs like you. I hope you have the opportunity in life to help make that a reality—either from work or by mentoring others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants