Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: DontCreateStringConstant #41

Merged
merged 12 commits into from
Feb 3, 2022
Merged

New rule: DontCreateStringConstant #41

merged 12 commits into from
Feb 3, 2022

Conversation

dykov
Copy link
Collaborator

@dykov dykov commented Jan 24, 2022

No description provided.

@dykov dykov linked an issue Jan 24, 2022 that may be closed by this pull request
Use MediaType#APPLICATION_JSON instead of hardcode string constants like "application/json" #25
Closed
@dykov dykov added the enhancement New feature or request label Jan 24, 2022
Oleksii Dykov added 4 commits January 30, 2022 00:55
rename the rule into UseExistingConstant
9f615a1
clean up
cee5811
Merge branch 'master' into feature/25
f727b3b 
# Conflicts:
#	src/main/resources/io/github/dgroup/arch4u/pmd/arch4u-template-ruleset.xml
use supplier instead of init method
e23c686
@dgroup dgroup added this to the 0.1.0 milestone Jan 30, 2022
Oleksii Dykov added 2 commits January 31, 2022 22:15
Merge branch 'master' into feature/25
0e31dcd 
# Conflicts:
#	src/main/resources/io/github/dgroup/arch4u/pmd/arch4u-ruleset.xml
move rule to the arch4u-error-handling-ruleset.xml
5fde1ba
@dykov dykov requested a review from dgroup January 31, 2022 20:22
@dykov dykov requested a review from dgroup February 3, 2022 21:20
@dykov dykov added the new rule label Feb 3, 2022
@dykov dykov changed the title New template rule: DontCreateStringConstant New rule: DontCreateStringConstant Feb 3, 2022
@dgroup
Copy link
Owner

dgroup commented Feb 3, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 3, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3c1cd41 into dgroup:master Feb 3, 2022
@rultor
Copy link
Collaborator

rultor commented Feb 3, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 2min)

@dykov dykov deleted the feature/25 branch February 5, 2022 23:11
@dgroup dgroup removed this from the 0.1.0 milestone Feb 11, 2022
@dgroup dgroup modified the milestone: 0.1.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgroup dgroup dgroup approved these changes

Assignees

@dykov dykov

Labels
enhancement New feature or request new rule
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Use MediaType#APPLICATION_JSON instead of hardcode string constants like "application/json"
3 participants
@dykov @dgroup @rultor