Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14: Configure 3rd-party rules #46

Merged
merged 1 commit into from
Jan 30, 2022
Merged

#14: Configure 3rd-party rules #46

merged 1 commit into from
Jan 30, 2022

Conversation

dgroup
Copy link
Owner

@dgroup dgroup commented Jan 30, 2022

#14

@dgroup dgroup added this to the 0.1.0 milestone Jan 30, 2022
This was linked to issues Jan 30, 2022
Define ruleset with third-party basic PMD rules --> #14
Closed
arch4u-recommended-thirdpary-ruleset.xml:35: Include this file into 'arch4u-ruleset.xml' once task #14 is done --> #35
Closed
@dgroup
Copy link
Owner Author

dgroup commented Jan 30, 2022

@rultor merge

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #46 (28c7ba5) into master (99a78df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     88.09%   88.09%           
  Complexity        9        9           
=========================================
  Files             1        1           
  Lines            42       42           
  Branches          3        3           
=========================================
  Hits             37       37           
  Misses            2        2           
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a78df...28c7ba5. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rultor
Copy link
Collaborator

rultor commented Jan 30, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 28c7ba5 into master Jan 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the 14 branch January 30, 2022 13:15
@rultor
Copy link
Collaborator

rultor commented Jan 30, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 2min)

@dgroup dgroup modified the milestone: 0.1.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
2 participants
@dgroup @rultor