Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: MissingMandatoryAnnotation #53

Merged
merged 5 commits into from
Feb 4, 2022
Merged

New rule: MissingMandatoryAnnotation #53

merged 5 commits into from
Feb 4, 2022

Conversation

dykov
Copy link
Collaborator

@dykov dykov commented Jan 31, 2022

No description provided.

@dykov dykov marked this pull request as draft January 31, 2022 21:25
@dgroup dgroup linked an issue Feb 2, 2022 that may be closed by this pull request
Annotation is present on method if {there is another annotation|method signature pattern} #28
Closed
2 tasks
@dykov dykov added enhancement New feature or request new rule labels Feb 3, 2022
@dgroup
Copy link
Owner

dgroup commented Feb 4, 2022

@rultor merge

@dgroup dgroup marked this pull request as ready for review February 4, 2022 20:02
@rultor
Copy link
Collaborator

rultor commented Feb 4, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3b89913 into dgroup:master Feb 4, 2022
@rultor
Copy link
Collaborator

rultor commented Feb 4, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 3min)

@dykov dykov changed the title Feature/28 New rule: MissingMandatoryAnnotation Feb 5, 2022
@dykov dykov deleted the feature/28 branch February 5, 2022 23:10
@dgroup dgroup modified the milestone: 0.1.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgroup dgroup dgroup approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request new rule
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Annotation is present on method if {there is another annotation|method signature pattern}
3 participants
@dykov @dgroup @rultor