-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with "<" character in HTML Notifications not escaped #2866
Comments
wow thanks for this, can you test if its the same with |
Hi Looking at the HTML source of the notification email, in the example given, the whole of CHANGELOG.txt is contained in the email, but Outlook renders the code. Copy/pasting the HTML from the notification email into chrome/firefox highlights the problem. This may only be a problem where the web page contains a .txt file and {{diff_full}} converts to HTML? |
I have further tested |
…scaped - except for our added/remove/changed markup
Ok hmm
I'm not sure what todo about the |
Many thanks for the work done on HTML format notifications. I don't really have any expectations regarding It was only the change to |
Describe the bug
It appears the < character is not escaped in HTML notifications.
The < character does not show and causes problems after it.
Version
v0.48.05
How did you install?
Docker
To Reproduce
Steps to reproduce the behavior:
on the notification:
0.47.00
The line "Visual Selector - Including <button> (#2686)" becomes - "Visual Selector - Including (#2686)"
0.46.00
The notification is truncated after - UI - Extract it cannot cope with <title>
No further lines are included in the notification.
Expected behavior
The notification body should show the whole {{diff_full}}
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Email application: Outlook
Email account: gmail
The text was updated successfully, but these errors were encountered: