Merge pull request #158 from dhensby/pulls/cavage-spacing

fix: remove spaces between comma separated values in the cavage signature header
dhensby · Nov 28, 2023 · 5567a17 · 5567a17
2 parents ebe32d4 + c2ef06f
commit 5567a17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/cavage/index.ts b/src/cavage/index.ts
@@ -190,7 +190,7 @@ export async function signMessage<T extends Request | Response = Request | Respo
         }),
         `headers="${headerNames.join(' ')}"`,
         `signature="${signature.toString('base64')}"`,
-    ].join(', ');
+    ].join(',');
     return {
         ...message,
         headers: {

diff --git a/test/cavage/new.spec.ts b/test/cavage/new.spec.ts
@@ -347,7 +347,7 @@ describe('cavage', () => {
                     'Content-Type': 'application/json',
                     'Digest': 'SHA-256=X48E9qOokqqrvdts8nOJRJN3OWDUoyWxBf7kbu9DBPE=',
                     'Content-Length': '18',
-                    'Signature': 'keyId="rsa-key-1", algorithm="hs2019", created=1402170695, expires=1402170995, headers="(request-target) (created) (expires) host digest content-length", signature="YSBmYWtlIHNpZ25hdHVyZQ=="',
+                    'Signature': 'keyId="rsa-key-1",algorithm="hs2019",created=1402170695,expires=1402170995,headers="(request-target) (created) (expires) host digest content-length",signature="YSBmYWtlIHNpZ25hdHVyZQ=="',
                 });
                 expect(signer.sign).to.have.been.calledOnceWithExactly(Buffer.from(
                     '(request-target): post /foo\n' +
@@ -388,7 +388,7 @@ describe('cavage', () => {
                     'Date': 'Tue, 20 Apr 2021 02:07:56 GMT',
                     'Content-Type': 'application/json',
                     'Content-Length': '62',
-                    'Signature': 'created=1618884479, keyId="test-key-ecc-p256", headers="content-length content-type", signature="YSBmYWtlIHNpZ25hdHVyZQ=="',
+                    'Signature': 'created=1618884479,keyId="test-key-ecc-p256",headers="content-length content-type",signature="YSBmYWtlIHNpZ25hdHVyZQ=="',
                 });
                 expect(signer.sign).to.have.been.calledOnceWithExactly(Buffer.from(
                     'content-length: 62\n' +