Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use scikit-build-core for the build #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

henryiii
Copy link

Getting started on #336 to see what it looks like.

@dhermes dhermes marked this pull request as ready for review October 1, 2024 14:39
@dhermes
Copy link
Owner

dhermes commented Oct 1, 2024

@henryiii Somehow I missed this in July, sorry! Just marked it "Ready for Review". Note that you'll want to rebase / merge main because some things have been updated (e.g. _speedup.c CI check fails if not up to date with latest Cython)

UPDATE: I now realize "Ready for Review" was the wrong button! I needed to click "Approve and run". DERP!

@henryiii henryiii force-pushed the henryiii/chore/skbc branch from c2134ec to 6e71632 Compare October 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants