fix: pivot table crashes when setting hide empty columns #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: syntax eerror chore: more debugging chore: more debugging 1 fix: more logging and potential fix fix: check that data[row] exists first
jenniferarnesen
force-pushed
the
fix/pivot-table-empty-row-crash
branch
from
d42ef25 to
8ec4533
Compare
jenniferarnesen
requested review from
janhenrikoverland
and removed request for
amcgee
amcgee
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
LGTM
An alternative would be to use optional chaining:
!!(this.data[row]?.[column])
But this should work just as well. I checked that data[row][column] should always be either undefined or an object/array, so we shouldn't run into issues with false-ish 0 or "". Would be good to refactor this to typescript though so that's actually guaranteed.
edoardo
approved these changes
Feb 4, 2025
dhis2-bot
added a commit
that referenced
this pull request
Feb 4, 2025
## [26.10.2](v26.10.1...v26.10.2) (2025-02-04) ### Bug Fixes * pivot table crashes when setting hide empty columns ([#1747](#1747)) ([f8c01cb](f8c01cb))
|
🎉 This PR is included in version 26.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-17876
Check that data[row] exists before accessing it.
I think this is where the error was introduced: https://github.com/dhis2/analytics/pull/1567/files#diff-cecda9e65f89fb79253f45505c2d7587509d804de707bfd659ee82d97234daa9R573