Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update semantic commit rules to allow merge commits #91

Merged
merged 2 commits into from
Nov 3, 2020
Merged

chore: update semantic commit rules to allow merge commits #91

merged 2 commits into from
Nov 3, 2020

Conversation

jenniferarnesen
Copy link
Contributor

This is in line with other DHIS2 repositories

@varl
Copy link
Contributor

varl commented Nov 3, 2020

Great, the master configuration installed with new versions of cli-style is:

titleOnly: false
commitsOnly: false
titleAndCommits: true
allowMergeCommits: true

Any reason to not use that?

@jenniferarnesen
Copy link
Contributor Author

Great, the master configuration installed with new versions of cli-style is:

titleOnly: false
commitsOnly: false
titleAndCommits: true
allowMergeCommits: true

Any reason to not use that?

Sure if that fixes the broken build on #90, then I'm happy :)

@jenniferarnesen jenniferarnesen changed the title fix: only check PR title for semantic rules chore: update semantic commit rules to allow merge commits Nov 3, 2020
@varl varl merged commit 7f7c00a into master Nov 3, 2020
@varl varl deleted the fix/semantic-on-pr-title-only branch November 3, 2020 13:57
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

varl pushed a commit that referenced this pull request Nov 6, 2020
@jenniferarnesen @varl
chore: update semantic commit rules to allow merge commits (#91)
2712934 
* fix: only check pr title for semantic

* fix: use recommended configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varl varl varl approved these changes

@janhenrikoverland janhenrikoverland Awaiting requested review from janhenrikoverland

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenniferarnesen @varl @dhis2-bot