Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep layer visibility when period is changed (DHIS2-15439) #2705

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

turban
Copy link
Contributor

@turban turban commented Jun 22, 2023

This PR will make sure the layer visibility is kept when the timeline period is changed.

Fixes: https://dhis2.atlassian.net/browse/DHIS2-15439

After this PR:
ezgif com-video-to-gif

@turban turban requested a review from jenniferarnesen June 22, 2023 14:12
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-2705--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 22, 2023 14:37 Inactive
@cypress
Copy link

cypress bot commented Jun 22, 2023

Passing run #2166 ↗︎

0 33 20 0 Flakiness 0

Details:

Merge 020e831 into d7172d4...
Project: maps Commit: ceac92458b ℹ️
Status: Passed Duration: 03:38 💡
Started: Jun 22, 2023 2:42 PM Ended: Jun 22, 2023 2:45 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@turban turban merged commit 491548b into dev Jun 27, 2023
@turban turban deleted the fix/DHIS2-15439 branch June 27, 2023 12:47
@turban turban changed the title fix: keep layer visibility when period is changed fix: keep layer visibility when period is changed (DHIS2-15439) Jul 31, 2023
dhis2-bot added a commit that referenced this pull request Aug 31, 2023
## [100.1.6](v100.1.5...v100.1.6) (2023-08-31)

### Bug Fixes

* **translations:** sync translations from transifex (dev) ([3a3b81e](3a3b81e))
* **translations:** sync translations from transifex (dev) ([3effb0d](3effb0d))
* keep layer visibility when period is changed ([#2705](#2705)) ([df32ea4](df32ea4))
* set period for each split view map ([#2721](#2721)) ([6ec0eba](6ec0eba))
* Set rendering strategy to single if not relative period ([#2703](#2703)) ([c47484b](c47484b))
* upgrade landcover dataset ([#2732](#2732)) ([3e93ced](3e93ced))
* **translations:** sync translations from transifex (dev) ([22d43c7](22d43c7))
* **translations:** sync translations from transifex (dev) ([b5da40a](b5da40a))
* **translations:** sync translations from transifex (dev) ([a090132](a090132))
* **translations:** sync translations from transifex (dev) ([21acc31](21acc31))
* **translations:** sync translations from transifex (dev) ([4597cbb](4597cbb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants