Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: enable PEP 740 attestations #291

Merged
merged 2 commits into from
Nov 6, 2024
Merged

release: enable PEP 740 attestations #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e43fc3
release: enable PEP 740 attestations
woodruffw Oct 4, 2024
c8c96cc
Merge branch 'main' into ww/enable-pep740
di Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
needs: [build, generate-provenance]
runs-on: ubuntu-latest
permissions:
id-token: write # To upload via OIDC.
id-token: write # To upload via OIDC + generate attestations.
steps:
- name: Download artifacts directories # goes to current working directory
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
Expand All @@ -73,24 +73,18 @@ jobs:
uses: pypa/gh-action-pypi-publish@61da13deb5f5124fb1536194f82ed3d9bbc7e8f3 # v1.12.0
with:
packages-dir: built-packages/
attestations: true

release-github:
needs: [build, generate-provenance]
runs-on: ubuntu-latest
permissions:
# Needed to upload release assets.
contents: write
# Needed to sign release assets.
id-token: write
steps:
- name: Download artifacts directories # goes to current working directory
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8

- name: Sign artifacts
uses: sigstore/[email protected]
with:
inputs: ./built-packages/*.tar.gz ./built-packages/*.whl

- name: Upload artifacts to GitHub
# Confusingly, this action also supports updating releases, not
# just creating them. This is what we want here, since we've manually
Expand Down