refactor: replace requests with urllib3 #333
Conversation
This simplifies our dependency tree a bit, since requests is built on urllib3 internally. It also chips away at a larger plan to replace requests with urllib3 in sigstore-python, per sigstore/sigstore-python#1040. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
There was a problem hiding this comment.
Looks good to me technically.
Should note that this PR switches the certificate store that id uses, see discussion in sigstore/sigstore-python#1040.
| else: | ||
| assert False | ||
|
|
||
| u3 = pretend.stub(request=_request, exceptions=pretend.stub(MaxRetryError=ValueError)) |
There was a problem hiding this comment.
could you avoid exceptions arg here by raising MaxRetryError in the first place?
There was a problem hiding this comment.
could you avoid exceptions arg here by raising MaxRetryError in the first place?
Unfortunately not: this happens because I stub out the entire urllib3 package, so urllib3.exeptions.MaxRetryError would no longer be the "same" type. I could probably do a more precise stub instead, but MaxRetryError is also an annoying one to raise in tests (since it needs to be initialized with a URL, connection pool, response, etc).
(WIP; haven't rewritten the GCP tests yet.)This simplifies our dependency tree a bit,
since requests is built on urllib3 internally.
It also chips away at a larger plan to replace
requests with urllib3 in sigstore-python, per
sigstore/sigstore-python#1040.