Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output response body when request fails #93

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Output response body when request fails #93

merged 1 commit into from
Aug 26, 2023

Conversation

di
Copy link
Owner

@di di commented Aug 25, 2023

@di di requested a review from woodruffw August 25, 2023 22:42
woodruffw
woodruffw approved these changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We could also do this with a logger.debug, but IMO this is good as well 🙂

@woodruffw woodruffw merged commit 1e8b59f into main Aug 26, 2023
@woodruffw woodruffw deleted the output-failed-response-body branch August 26, 2023 03:30
This was referenced Aug 26, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear error message "GCP: OIDC token request failed (code=404)"
2 participants
@di @woodruffw