Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct and complete #6844

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Correct and complete #6844

merged 1 commit into from
Nov 30, 2023

Conversation

hiperiondev
Copy link
Contributor

Correct some translations and complete with new ones

@AJenbo AJenbo merged commit fd0b528 into diasurgical:master Nov 30, 2023
19 checks passed
@julealgon
Copy link
Contributor

@hiperiondev if you could use more descriptive titles in your future PRs that would be awesome. Thanks!

@qndel
Copy link
Member

qndel commented Nov 30, 2023

also dumping all changes in 1 commit makes it hard to review, make 1 commit for syncing with master and 1 for actual translation changes

@hiperiondev
Copy link
Contributor Author

@hiperiondev if you could use more descriptive titles in your future PRs that would be awesome. Thanks!

I agree with this, I will do it in the next change.

@hiperiondev
Copy link
Contributor Author

also dumping all changes in 1 commit makes it hard to review, make 1 commit for syncing with master and 1 for actual translation changes

It is true, that is why perhaps I could indicate in the comment which terms were modified or added in the translation.
Since I do not review the translation very regularly, it tends to grow very quickly (although it tends to take "jumps" in the number of changes, rather than increasing regularly), so I will try to do it more regularly (one month is my intention).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants