Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell softcaps #7689

Closed
wants to merge 1 commit into from
Closed

Add spell softcaps #7689

wants to merge 1 commit into from

Conversation

vlolteanu
Copy link
Contributor

Some spells gain absolutely nothing past a certain point, other than being better victims for the Enchanted shrine.

RuneOfNova Rune of Nova CastHealing 800 30 255 Magic,Targeted -1 -1 48 RuneOfNova 1 10 40 80
RuneOfImmolation Rune of Immolation CastHealing 800 30 255 Magic,Targeted -1 -1 48 RuneOfImmolation 1 10 40 80
RuneOfStone Rune of Stone CastHealing 800 30 255 Magic,Targeted -1 -1 48 RuneOfStone 1 10 40 80
id name soundId bookCost10 staffCost10 manaCost flags bookLevel staffLevel minIntelligence missiles manaMultiplier minMana staffMin staffMax softCap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be a tab.

Suggested change
id name soundId bookCost10 staffCost10 manaCost flags bookLevel staffLevel minIntelligence missiles manaMultiplier minMana staffMin staffMax softCap
id name soundId bookCost10 staffCost10 manaCost flags bookLevel staffLevel minIntelligence missiles manaMultiplier minMana staffMin staffMax softCap

@DakkJaniels
Copy link
Contributor

It doesn't look like this factors in class based reduced mana cost. For example, phasing would soft cap at level 3 for a class with 50% mana reduction.

That being said, I'm not sure this is really necessary, and might create some more confusion from people (why is my level 10/3???)

Immolation Immolation CastFire 2100 130 60 Fire 14 10 87 Immolation 3 35 16 32 0
Warp Warp CastSkill 300 20 35 Magic 3 3 25 Warp 3 18 8 12 7
Reflect Reflect CastSkill 300 20 35 Magic 3 3 25 Reflect 3 15 8 12 0
Berserk Berserk CastSkill 300 20 35 Magic,Targeted 3 3 35 Berserk 3 15 8 12 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Berserk spell level adds to monster damage. It is not capped at 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same percentage-based increase no matter the level, but the mana cost caps at 8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell level does appear to factor in.

monster.minDamage = (GenerateRnd(10) + 120) * monster.minDamage / 100 + slvl;
monster.maxDamage = (GenerateRnd(10) + 120) * monster.maxDamage / 100 + slvl;
monster.minDamageSpecial = (GenerateRnd(10) + 120) * monster.minDamageSpecial / 100 + slvl;
monster.maxDamageSpecial = (GenerateRnd(10) + 120) * monster.maxDamageSpecial / 100 + slvl;

@vlolteanu
Copy link
Contributor Author

It doesn't look like this factors in class based reduced mana cost. For example, phasing would soft cap at level 3 for a class with 50% mana reduction.

Nope, I had no idea about mana cost reduction. That just about kills this PR.

That being said, I'm not sure this is really necessary, and might create some more confusion from people (why is my level 10/3???)

@vlolteanu vlolteanu closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants