Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple syntax errors in documentation #131

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

diazona
Copy link
Owner

@diazona diazona commented Dec 10, 2023

Fairly straightforward, just fixing a couple of errors. In both cases I lamented the lack of a good pre-commit hook to catch this sort of thing, so maybe we can find one and add it in the future.

Closes #129
Closes #130

This snippet of documentation was in an .rst file and should have been
in Restructured Text syntax, but it was actually in Markdown, so it
wasn't rendering properly in the final documentation. I'm fixing that
with this commit.

It would be nice if we had a pre-commit hook to check .rst syntax, it
probably would have caught this, but I haven't found a really good hook
for that yet.
I used the wrong link syntax in a docstring, so I'm fixing that here.

This is another case where a suitable pre-commit hook would have helped,
though in this case we'd need one able to check RST syntax in docstrings
specifically. I'm not sure if there is a good hook that does that.
@diazona diazona added the documentation Improvements or additions to documentation label Dec 10, 2023
@diazona diazona added this to the v0.2 milestone Dec 10, 2023
@diazona diazona requested a review from sjlongland December 10, 2023 06:10
@sjlongland sjlongland merged commit 63e9d94 into main Dec 10, 2023
12 checks passed
@sjlongland sjlongland deleted the docs-errors/1/dev branch December 10, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in documentation syntax - badly formatted link Error in documentation syntax
2 participants