Bug: Uploaded date for files is invalid

[maximmax42]

What happened?

All (but one) of my files in the gallery show this instead of the actual date:

And one file shows this:

Except its actual upload date is this:

Something somewhere thinks that the date format is mm.dd.yyyy, even though both my host and my own pc use dd.mm.yyyy.

Dashboard's main page shows a proper upload date.

Version

upstream (ghcr.io/diced/zipline:trunk)

What browser(s) are you seeing the problem on?

Chromium-based (Chrome, Edge, Brave, Opera, mobile chrome/chromium based, etc)

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response

[diced]

Not sure if this will fix it but, the path Zipline is on in the docker file is /app now, make sure your volumes use /app instead of /zipline.

[diced]

Something somewhere thinks that the date format is mm.dd.yyyy, even though both my host and my own pc use dd.mm.yyyy.

That's weird... It should be using your browsers locale format, which i'm guessing is probably dd.mm.yyy

[maximmax42]

Not sure if this will fix it but, the path Zipline is on in the docker file is /app now, make sure your volumes use /app instead of /zipline.

I tried a build before the 70c2fa8 commit, same thing. But thanks, that should probably fix the other issue I've opened.

That's weird... It should be using your browsers locale format, which i'm guessing is probably dd.mm.yyy

Yup, dd.mm.yyyy everywhere.

[diced]

Yup, dd.mm.yyyy everywhere.

Hold on, is it using that format, or are you just saying it should be using that?

[maximmax42]

It should be using dd.mm.yyyy, but somehow, and only in the gallery's file cards, it's trying to read a dd.mm.yyyy date as a mm.dd.yyyy.

[maximmax42]

Creation time in the URL card in the /dashboard/urls also shows just fine.

[maximmax42]

Update: 3.5.1 displays everything just fine, 3.6.0 and onwards doesn't. Might be the relative time package?

[TacticalTechJay]

Do you have any sample data of any image directly from the db that has this problem?

[maximmax42]

COPY public."File" (id, name, mimetype, "createdAt", views, "userId", favorite, embed, format, password, "expiresAt", "maxViews", "originalName") FROM stdin;
12	72mBg.txt	text/plain	2022-10-28 10:55:33.642	86	1	f	t	RANDOM	\N	\N	\N	\N
23	hciKJ.mp4	video/mp4	2022-11-04 12:04:46.088	3	1	f	t	RANDOM	\N	\N	\N	\N

First one shows "NaN years ago" and "Invalid Date", second shows "10 months ago" and "11.04.2022, 17:04:46".
My system format is dd.mm.yyyy everywhere, timezone is UTC+5.

[maximmax42]

I'm breaking my goddamn brain over this. I don't get it. Apparently new Date('2022-11-04 12:04:46.088') just doesn't produce a proper Date object. Is there any way to change the way how the dates are stored in the database to proper ISO 8601 (YYYY-MM-DDTHH:mm:ss.sssZ)?

[maximmax42]

Uh... I see what the problem is apparently. Why is image.createdAt in

zipline/src/components/File.tsx

Line 257 in 6955d83

subtitle={relativeTime(new Date(image.createdAt))}

already a localized string (a la "23.02.2023, 19:04:11") instead of whatever format should be returned from the db? Is it because of this?

zipline/src/lib/queries/files.ts

Line 26 in 6955d83

createdAt: new Date(x.createdAt).toLocaleString(),

Trying to do new Date("23.02.2023, 19:04:11") does indeed produce an incorrect date, but new Date('2023-02-23 19:04:11.000') would produce a proper date.

[TacticalTechJay]

You could try forking zipline and changing the end of this

zipline/src/lib/queries/files.ts

Line 26 in 6955d83

createdAt: new Date(x.createdAt).toLocaleString(),

to toISOString().

[diced]

Uh... I see what the problem is apparently. Why is image.createdAt in

zipline/src/components/File.tsx

Line 257 in 6955d83

subtitle={relativeTime(new Date(image.createdAt))}

already a localized string (a la "23.02.2023, 19:04:11") instead of whatever format should be returned from the db? Is it because of this?

zipline/src/lib/queries/files.ts

Line 26 in 6955d83

createdAt: new Date(x.createdAt).toLocaleString(),

Trying to do new Date("23.02.2023, 19:04:11") does indeed produce an incorrect date, but new Date('2023-02-23 19:04:11.000') would produce a proper date.

Ah.. I see, it shouldn't be localized at all in the file query.

[maximmax42]

You could try forking zipline and changing the end of this

zipline/src/lib/queries/files.ts

Line 26 in 6955d83

createdAt: new Date(x.createdAt).toLocaleString(),

to toISOString().

Surprisingly, that didn't help. But now I have this.

Guess it's not that line in particular. Trying line 42.

[maximmax42]

Okay, so, yeah.

zipline/src/lib/queries/files.ts

Line 42 in 6955d83

.then((data) => data.map((x) => ({ ...x, createdAt: new Date(x.createdAt).toLocaleString() })));

and

zipline/src/lib/queries/files.ts

Line 53 in 6955d83

createdAt: new Date(x.createdAt).toLocaleString(),

need to be ISO strings. Or just untouched.

[diced]

Can you take a look at the above commit and see if it fixes the issues you have?

I've just removed the toLocaleString from all of them, and replaced with Dates.

fdcd1f3

[maximmax42]

Can you take a look at the above commit and see if it fixes the issues you have?

I've just removed the toLocaleString from all of them, and replaced with Dates.

fdcd1f3

Yeah, this works.

Except there's this mess now:

[TacticalTechJay]

Hmm... I suppose that's a step.

[maximmax42]

So, e804d0b has fixed the previously mentioned mess, and it all looks nice.

With that, I think this issue can be closed.

[diced]

Yep! Forgot to let you know yesterday, my bad. If there are any more problems after this feel free to post another comment and reopen.