Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Original filename isn't saved in UTF-8 #317

Closed
maximmax42 opened this issue Mar 6, 2023 · 3 comments · Fixed by #324
Closed

Bug: Original filename isn't saved in UTF-8 #317

maximmax42 opened this issue Mar 6, 2023 · 3 comments · Fixed by #324
Labels
bug Something isn't working
Milestone

Comments

@maximmax42
Copy link
Contributor

maximmax42 commented Mar 6, 2023

What happened?

Steps to reproduce:

  1. Upload a file with non-Latin letters in the name, for example: тест.png
  2. Try to use {file.originalName}

Expected: тест.png
Actual: ��.png

Checked the database, it gets saved with the wrong encoding there.

Version

upstream (ghcr.io/diced/zipline:trunk)

What browser(s) are you seeing the problem on?

No response

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response

@maximmax42 maximmax42 added the bug Something isn't working label Mar 6, 2023
@TacticalTechJay
Copy link
Collaborator

Does it affect zipline in any way? I saved the file with that original name and noticed no issues

@maximmax42
Copy link
Contributor Author

maximmax42 commented Mar 11, 2023

I mean, it doesn't break Zipline, it just shows gibberish in the Discord embeds if you try to use the original filename.

@TacticalTechJay
Copy link
Collaborator

I see, thanks for clarifying the problem.

@diced diced added this to the 3.7.0 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants