-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and Feature dump #324
Merged
Merged
Fix and Feature dump #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: compression for the raw route feat: compression being noticable on dashboard feat: add configuration for compression, will be disabled by default
diced
requested changes
Mar 19, 2023
diced
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #318 and fix #317.
Along with that, it adds the following:
content-encoding
header) for the raw route, can be applied to the dashboard where files could be previewed.CORE_COMPRESSION_ENABLED
,CORE_COMPRESSION_THRESHOLD
, andCORE_COMPRESSION_ON_DASHBOARD
variables. this will be disabled by default, Their types areboolean
,human-to-byte
, andboolean
. on_dashboard will have compressed file previews being served on the dashboardnpm i
/dashboard
and/files